Skip to content

change new Buffer to Buffer.from - #27

Closed
nektro wants to merge 1 commit into
pgilad:masterfrom
nektro:patch-1
Closed

nektro wants to merge 1 commit into
pgilad:masterfrom
nektro:patch-1

Conversation

@nektro

@nektro nektro commented Sep 24, 2018

Copy link
Copy Markdown
Contributor

new Buffer has been deprecated in node 10 (nodejs/node#8169)

`new Buffer` has been deprecated in node 10 (nodejs/node#8169)
@pgilad

pgilad commented Sep 24, 2018

Copy link
Copy Markdown
Owner

Thanks a bunch my friend!

@pgilad

pgilad commented Sep 25, 2018

Copy link
Copy Markdown
Owner

I did a mistake when merging (it didn't preserve author) so I rebased your commit and now you are properly in the git log. Sorry about that!
b2d47b9

@nektro

nektro commented Sep 26, 2018

Copy link
Copy Markdown
Contributor Author

No worries 😅 thanks so much though! Glad I could help :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants