Fix lint warnings (closes #146) - #158
Merged
Merged
Conversation
- Add argsIgnorePattern/varsIgnorePattern for _ prefix convention - Add gitignore folder to ESLint global ignores - Remove unused imports/variables (X, totalPages, openDropdown, container, matchingHeaders, TokenGroup, err) - Fix react-hooks/exhaustive-deps by wrapping rows in useMemo - Remaining 61 warnings are all no-explicit-any (intentional)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces lint warnings from 82 → 61 (all remaining are intentional
no-explicit-any).Changes
argsIgnorePattern: "^_"andvarsIgnorePattern: "^_"tono-unused-varsrule, respecting the underscore prefix convention. Addedgitignoreto global ignores.Ximport (MessageBanner),totalPagesvariable (ReadOnlyGrid),openDropdownhelper (DropdownField test),containerdestructuring (RadioButton test),matchingHeaders(ReadOnlyGrid test),TokenGroupinterface (generate-css), unusederrcatch binding (token-server).rowsnormalization inReact.useMemoto stabilize the dependency for downstream memos."warn"— these are intentional for SAIL-mirroring polymorphic props (value,saveInto,choiceLabels,data, etc.).Verification
pnpm run typecheck— cleanpnpm run lint— 0 errors, 61 warnings (allno-explicit-any)pnpm run test— 466 tests passing