add Decidable instances for ->, Neg and Either#4
Open
olafklinke wants to merge 2 commits intophadej:masterfrom
Open
add Decidable instances for ->, Neg and Either#4olafklinke wants to merge 2 commits intophadej:masterfrom
olafklinke wants to merge 2 commits intophadej:masterfrom
Conversation
add instances `Decidable a => Decidable (Neg a)` `(Decidable a, Decidable b) => Decidable (a -> b)` `(Decidable a, Decidable b) => Decidable (Either a b)`
phadej
requested changes
Mar 23, 2023
| (Yes _, Yes b) -> Yes (const b) | ||
|
|
||
| -- | Disjunctions are decidable | ||
| instance forall a b. (Decidable a, Decidable b) => Decidable (Either a b) where |
Owner
There was a problem hiding this comment.
This is not lawful instance as it prefers Left over right.
a should be a Proposition, i.e. the Yes answers should be unique.
Author
There was a problem hiding this comment.
What is actually meant by the 'Yes' answers should be unique? Can you give an example how this breaks? (I don't know the use-case of this library so I can't think of why this instance is bad.) Preferring left over right corresponds to short-circuiting which is generally a welcome property in logic, no?
Decidability for `Neg a` is subsumed by decidability of implication. Avoid overlapping instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add instances
Decidable a => Decidable (Neg a)(Decidable a, Decidable b) => Decidable (a -> b)(Decidable a, Decidable b) => Decidable (Either a b)