Switch build to Mill - #31
Merged
Merged
Conversation
phaller
reviewed
Apr 2, 2026
| import com.github.lolgab.mill.mima._ | ||
|
|
||
| val scala3 = "3.3.7" | ||
| val scalaJS = "1.19.0" |
Owner
There was a problem hiding this comment.
Should we use Scala.js 1.20.2? It was released in January:
https://www.scala-js.org/news/2026/01/05/announcing-scalajs-1.20.2/
| val scala3 = "3.3.7" | ||
| val scalaJS = "1.19.0" | ||
| val scalaNative = "0.5.8" | ||
| val upickle = "3.3.0" |
Owner
There was a problem hiding this comment.
Might want to upgrade this as well.
Contributor
Author
There was a problem hiding this comment.
I looked into upgrading uPickle to 4.X and this will require some changes to the test cases as the newer uPickle versions produce different serialized output. I have another PR that addresses this and bumps the uPickle version to 4.X. So I will leave the uPickle version at 3.3.0 for this PR.
- Add Mill build instead of SBT - Move source and test files to work with standard Mill directory layout - Use uTest instead of JUnit4 - Fix GitHub Actions to use Mill - Bump Scala.js and Scala Native versions: Scala.js "1.19.0" -> "1.20.2"; Scala Native "0.5.8" -> "0.5.10" - Bump Spores3 version: "0.2.0" -> "0.3.0-SNAPSHOT"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces sbt build with Mill. JUnit4 is replaced with uTest as I could not get it working with Mill on Scala Native / JS.
The PR is submitted as four commits so that it is easier to track the changes. They should be squashed and signed before merge.