Change JSON serialization format - #32
Merged
Merged
Conversation
- Update tests to work with new serialization format - Bump uPickle version: "3.3.0" -> "4.4.3" - Replace the `Packed` spore representation with AST spore representation: now contains the value to be serialized whereas previously it was the serialized value - Remove Spore[ReadWriter[EmptyTuple]] - Add tests for serialization format
phaller
self-requested a review
April 8, 2026 13:48
phaller
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a custom serialization format that does not depend on the uPickle default format.
Packedspore representation with AST spore representation: now contains the value to be serialized whereas previously it was the serialized valueOther notes: I had to change the Scala Native version from 0.5.10 to 0.5.9 as the GitHub Actions runners otherwise (on 0.5.10) would frequently hang.
Here are some before/after examples:
Object builder:
Before:
After:
Class builder:
Before:
After:
Lambda builder:
Before:
After:
With environment builder:
Before:
After (it is no longer necessary to escape by ""):