Unify Spore factory methods - #37
Open
jspenger wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Future improvement: |
- Replace existing Spore factory methods: `Spore.apply(body)`, `Spore.applyWithEnv(env)(body)`, `Spore.applyWithCtx(env)(body)` with new uniform method: `Spore.apply(captures)(body)`, where `captures` is either an explicit list of the captured variables, or the symbol `*` for capturing all variables
- Example: `val y = 12; val z = 13; Spore(y, z) { (x: Int) => x + y + z }`
- Example: `Spore(*) { (x: Int) => x + y + z }`
- Update all test cases and samples to use new factory method(s)
- Update macros and refactoring
- Add inlined factory-alias tests
jspenger
force-pushed
the
spore-apply-factory
branch
from
April 15, 2026 15:40
6ea4bd6 to
e3d9a1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies the Spore factory methods.
Before, the factory methods consisted of:
Spore.apply(body),Spore.applyWithEnv(env)(body),Spore.applyWithCtx(env)(body).These are replaced by
Spore(captures...)(body), wherecapturesis either an explicit list of the captured variables, or the symbol*for capturing all variables.Examples:
A Spore with no captures
A Spore with explicit captures
A Spore with
*capture all modeInvalid capturing causes a compiler error.