Fix GitHub Actions for Windows - #38
Merged
Merged
Conversation
Fail actions on Windows if there are failed tests Add JDK 25 to matrix
phaller
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with Windows not failing on GitHub Actions even though some of the test cases fail.
I noticed this issue sometime last week. To demonstrate it, I added a failing test case
testAlwaysFailwithassert(false). All GitHub Actions runs fail except for Windows: https://github.com/jspenger/spores3/actions/runs/24459027889. This is fixed by this PR: https://github.com/jspenger/spores3/actions/runs/24460187815.(Also adds JDK 25.)