Skip to content

create an ard_stack class#578

Merged
ddsjoberg merged 4 commits into
pharmaverse:mainfrom
alanahjonas95:issue_577
Jul 13, 2026
Merged

create an ard_stack class#578
ddsjoberg merged 4 commits into
pharmaverse:mainfrom
alanahjonas95:issue_577

Conversation

@alanahjonas95

@alanahjonas95 alanahjonas95 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

resolves #577

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Optional Reverse Dependency Checks:

Install checked with pak::pak("Genentech/checked") or pak::pak("checked")

# Check dev versions of `cardx`, `gtsummary`, and `tfrmt` which are in the `ddsjoberg` R Universe
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2L, repos = c('https://ddsjoberg.r-universe.dev', 'https://cloud.r-project.org'))"

# Check CRAN reverse dependencies but run tests skipped on CRAN
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

# Check CRAN reverse dependencies in a CRAN-like environment
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = FALSE), checked.check_build_args = '--as-cran'); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

@ddsjoberg ddsjoberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 thanks @alanahjonas95 !

@ddsjoberg

Copy link
Copy Markdown
Collaborator

Can you fix this URL as well, please (unrelated)?

image

@alanahjonas95

alanahjonas95 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Can you fix this URL as well, please (unrelated)?

image

ive updated the old cards location ones but not sure what to do with the cdisc one looks like theres an issue on their website:
image

@ddsjoberg ddsjoberg merged commit 6b34b8c into pharmaverse:main Jul 13, 2026
33 of 37 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2026
@ddsjoberg

Copy link
Copy Markdown
Collaborator

Thanks @alanahjonas95 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: ard_stack retains bind_ard attribute as it uses this function

2 participants