Skip to content

Fix Mosswort Bridge hideaway card visible to opponent (#4828)#4842

Open
kiannidev wants to merge 3 commits into
phase-rs:mainfrom
kiannidev:fix/4828-mosswort-hideaway-visibility
Open

Fix Mosswort Bridge hideaway card visible to opponent (#4828)#4842
kiannidev wants to merge 3 commits into
phase-rs:mainfrom
kiannidev:fix/4828-mosswort-hideaway-visibility

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Apply the Hideaway look-permission gate to exile ghost cards shown under hideaway permanents on the battlefield
  • Opponents now see a face-down placeholder instead of the hidden card's name and art

Test plan

Fixes #4828

ExileGhostCard on hideaway permanents now uses the same look-permission gate as ZoneViewer so opponents see a face-down placeholder instead of the hidden card identity.

Fixes phase-rs#4828
@kiannidev kiannidev requested a review from matthewevans as a code owner July 2, 2026 00:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses issue #4828 by ensuring that face-down exiled cards (such as those exiled via Hideaway) are properly hidden from the opponent on the source permanent's exile ghost in the UI. It introduces a hiddenFromViewer check in ExileGhostCard using isFaceDownExileCardVisibleToViewer and adds a corresponding unit test to verify this behavior. I have no feedback to provide as there are no review comments to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Use the discriminated NoCost shape without Cost-only fields so type-check
passes in the frontend workflow.

Co-authored-by: Cursor <cursoragent@cursor.com>
@matthewevans matthewevans added defer-fe Frontend/client/UI PR deferred to Matt's direct review bug Bug fix labels Jul 2, 2026
@matthewevans matthewevans self-assigned this Jul 8, 2026
# Conflicts:
#	client/src/components/board/PermanentCard.tsx
@matthewevans matthewevans removed their assignment Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix defer-fe Frontend/client/UI PR deferred to Matt's direct review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mosswort Bridge hideaway card is visible to the opponent

2 participants