refactor(oracle-gen): drop stats flag from CardWorkCtx; count unimplemented faces unconditionally#5460
Merged
Merged
Conversation
…mented faces unconditionally Review follow-up for PR #5458: the per-face unimplemented scan is trivial next to the parse, so the counter is always computed and --stats gates only the printout. Removes the CLI coupling (and the bool field) from the worker context.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Parse changes introduced by this PRBaseline pending for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-up for #5458 (branch was merge-queue-frozen when the fix was ready, so it lands separately).
Addresses the Gemini
[HIGH]bool-field finding onCardWorkCtx— by removal rather than aStatsModeenum: the per-facecard_face_has_unimplemented_partsscan is trivial next to the ~5ms/card parse, sounimplemented_facesis now computed unconditionally and--statsgates only the printout (its actual meaning). The worker context loses the CLI coupling entirely.No behavior change to any output:
card-data.json/card-names.jsonare unaffected (the counter feeds only the--statsstderr report, whose gate is unchanged at the print site). Verified clean under clippy-D warnings.