Skip to content

Add distinction between movement and letter keys#733

Merged
phase1geo merged 1 commit into
phase1geo:masterfrom
argothth:fix-732
Jul 10, 2026
Merged

Add distinction between movement and letter keys#733
phase1geo merged 1 commit into
phase1geo:masterfrom
argothth:fix-732

Conversation

@argothth

@argothth argothth commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #732

  • Add a condition to check whether the pressed key is a symbol or movement key in matches_keypress
  • Update the execute function to match the signature of matches_keypress

Test ran:

  1. With my custom keyboard layout, I opened Minder;
  2. I pressed Enter on the root node to validate that text is saved;
  3. I pressed E (which is also up arrow key for me if I press AltGr) and successfully edited the text.

Fixes phase1geo#732

- Add a condition to check whether the pressed key is a symbol or movement key
in matches_keypress
- Update the execute function to match the signature of matches_keypress
@phase1geo phase1geo self-assigned this Jul 10, 2026
@phase1geo
phase1geo merged commit fac9947 into phase1geo:master Jul 10, 2026
1 check passed
@phase1geo

Copy link
Copy Markdown
Owner

Thank you for the improvement PR. Nice improvement!

@argothth

Copy link
Copy Markdown
Contributor Author

Thanks for merging it :))

@argothth
argothth deleted the fix-732 branch July 10, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AltGr/Layer3 key presses incorrectly understood for movement keys (very niche)

2 participants