bump 0.7.10#159
Conversation
6e6c9b3 to
091b180
Compare
|
Can you provide a briefing of implemented changes? This PR is huge. |
72a7a10 to
d18de16
Compare
Resolve project roots per document and defer heavy startup indexing when opening aggregate folders so go-to-definition works in nested C3 projects. Also harden document lookup paths and add typeDefinition support for editor compatibility.
|
AI generated (Claude-Opus-4.6) PR #159 Brief — c3-lsp v0.7.10
|
|
This single PR bundles parser upgrade, new LSP methods, completion rewrite, workspace model changes, editor compat fixes, and rename support. It would be far easier to review and bisect regressions if split into 3-4 focused PRs |
DrEverr
left a comment
There was a problem hiding this comment.
TLDR: fix the Makefile path, add a PR description, and clean up the commit history. Ideally split the parser vendor from the feature work.
No PR description — The body is empty. A 93-file, 6-commit PR with this scope needs a summary explaining intent, testing done, and any breaking changes. The changelog is there but doesn't substitute for PR-level context.
Two of six commits are just "wip" with no meaningful message. This should be squashed or rebased into logical, reviewable units before merge.
There are new tests, but the ratio of new logic (completion rewrite, rename, implementation, workspace root resolution, config reload) to test coverage feels low. Several new handlers (TextDocumentRename, TextDocumentImplementation, TextDocumentTypeDefinition, WorkspaceDidChangeConfiguration) have minimal or basic tests.
Per-request recover() wrappers are a reasonable band-aid, but they mask root causes. The nil-deref fixes are good, but blanket recovery suggests there may be more lurking.
Worth noting in review that this shouldn't be the long-term strategy.
| .PHONY: * | ||
|
|
||
| ASSETS_DIR = assets | ||
| TREE_SITTER_LOCAL_DIR ?= /Users/f00lg/github/c3/tree-sitter-c3 |
There was a problem hiding this comment.
This should either be removed or set to a sensible default / documented as env-only.
There was a problem hiding this comment.
parser.c is 170k+ additions. It's nearly impossible to review meaningfully. The PR should either: vendor it in a separate commit clearly marked as generated, or better, exclude it and rebuild via CI.
No description provided.