Call shell script (see other pull request in phhusson/device_phh_treble)#28
Open
fourofspades wants to merge 2 commits into
Open
Call shell script (see other pull request in phhusson/device_phh_treble)#28fourofspades wants to merge 2 commits into
fourofspades wants to merge 2 commits into
Conversation
Owner
|
The code is fine, but please rebase into just one commit, and make a proper commit message saying this is to remove telephony |
fourofspades
force-pushed
the
Issue_#1141_TabletMode
branch
from
0c667ae to
218f165
Compare
Author
|
Do I need to do any more work on this pull request? |
Owner
|
Could you rebase? |
Author
|
OK, rebased. |
Author
|
Think I have done this correctly, don't really use GIT and rebasing much in my usual GIT usage. |
Owner
|
Not really, there is supposed to be no "Merge " commits Assuming my remote is |
fourofspades
force-pushed
the
Issue_#1141_TabletMode
branch
from
f9dc4e5 to
218f165
Compare
fourofspades
force-pushed
the
Issue_#1141_TabletMode
branch
from
218f165 to
ae44b04
Compare
Owner
|
that's still not ok, but I'll merge manually, thanks |
AndyCGYan
pushed a commit
to AndyCGYan/treble_app
that referenced
this pull request
Jan 21, 2024
Add Transsion DT2W
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call shell script.