Fix incorrect inputOffset after Skip with seeker#37
Open
mhr3 wants to merge 1 commit intophilhofer:masterfrom
Open
Fix incorrect inputOffset after Skip with seeker#37mhr3 wants to merge 1 commit intophilhofer:masterfrom
mhr3 wants to merge 1 commit intophilhofer:masterfrom
Conversation
Seek returns the new absolute position, not the number of bytes moved. The code was treating the return value as a delta, which caused inputOffset and the returned skip count to be wrong whenever the underlying stream was not at position 0 (i.e. after any prior reads). Use the known seek delta (n - skipped) directly instead of the absolute position returned by Seek. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reader.Skip:Seekreturns the new absolute position in the stream, not the number of bytes moved. The code was treating the return value as a delta, causinginputOffsetand the returned skip count to be wrong whenever the underlying stream position was non-zero (i.e. after any prior reads).n - skipped) directly instead of the absolute position returned bySeek. Also properly handleSeekerrors by returning early before updatinginputOffset.TestSkipSeekInputOffsetthat exercises the bug scenario: reads bytes first to advance the stream, then skips with seek, and verifiesInputOffset()and data correctness.Test plan
TestSkipSeekInputOffsetverifies correct offset tracking after read + seek-skipTestSkipSeekandTestInputOffsetcontinue to passMade with Cursor