stop sending mine=true into playlistItems#78
Open
alexanderadam wants to merge 1 commit into
Open
Conversation
problem was: open "my playlists", click any list, get items from a totally different one. happens because mine=true was kept in the per-item passthrough. when LMS then asked playlistItems.list for one specific playlist, mine=true was still attached and YT returned whatever first matched the auth context, not the requested playlistId. mine is only valid on playlists.list. keep it there, drop it from the per-item bag, and also delete it again in playlistHandler so we cant trip on it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem was: open "my playlists", click any list, get items from a totally different one. happens because mine=true was kept in the per-item passthrough. when LMS then asked playlistItems.list for one specific playlist, mine=true was still attached and YT returned whatever first matched the auth context, not the requested playlistId.
mine is only valid on playlists.list. keep it there, drop it from the per-item bag, and also delete it again in playlistHandler so we cant trip on it later.