Refactor: clean, secure, scalable codebase#3
Merged
Conversation
- Consolidate 17 icon components into Icons.jsx (from 5+ scattered files) - Extract useEscapeKey hook to eliminate duplicate modal escape handlers - Split SettingsModal (481 lines) into AccountTab, FormatsTab, AboutTab - Add ErrorBoundary wrapping the app in main.jsx - Extract localStorage key constants to constants.js - Fix timer memory leaks in OutputBox and ExportModal (useRef + cleanup) - Clear Google Drive access token on sign-out - Add input validation to openai.js, exportFile.js, googleDrive.js - Add Firebase env var validation with soft console.error - Consolidate hardcoded CSS values into custom properties - Add sidebar auto-collapse on window resize below 768px - Fix outdated privacy text in AboutTab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Icons.jsxregistryuseEscapeKeyhook and fixed timer memory leaks in OutputBox/ExportModalSettingsModalintoAccountTab,FormatsTab,AboutTabsub-componentsErrorBoundarywrapping the app for graceful error handlingconstants.jsto eliminate magic stringsopenai.js,exportFile.js,googleDrive.js--color-error,--color-success,--overlay-bg,--modal-z,--icon-btn-size)Test plan
npm run buildsucceeds