MouseMove event prevents onClick handler from firing

[russellsmith]

This problem occurs when events are handled in the following order:

1.   User clicks down on their mouse which fires the mouseDown event.  This results in a Boolean called ‘pressed’ to bet set to true.
   

2.   Browser fires off a mouseMove event which checks if pressed is true, and if so sets a Boolean ‘moved’ to true to indicate the user is click+dragging.
   

3.   User releases mouse which fires mouseUp event.  Normally this would then fire the onClick handler, if one exists, but if moved is set to true this doesn’t get called.
   

MouseMove will fire at times even when the mouse is not moving which prevents onClick handlers from firing reliably. This check to see that at least one pixel of movement occurred has alleviated this for me.

[russellsmith]

Whoops, had intended for only the last commit to be in the request. Guess that's not possible?

[philogb]

Why are you removing the merge operation? The idea is to clone the object.

[russellsmith]

In my application I'm adding Ember.js objects to my the data hash. Ember objects have observer functions tied to data properties that will get fired when a property is modified. The merge operation copies the data but in doing so unsets the observers.

In my case I don't want to have a clone of the object in this hash, I want the object itself so that the object state remains consistent within the application. I hadn't intended for this change to be a part of the pull request, but why does the object need to be cloned in the first place?