fix(engine): address four Copilot review comments on PR #433

- vitest.config.mjs: move coverage block inside test:{} so Vitest
  applies it correctly (top-level coverage is ignored)
- check.mjs: detect package manager from package.json#packageManager
  or lockfiles instead of hardcoding pnpm; npm projects now use
  'npm run typecheck', yarn uses 'yarn typecheck', pnpm unchanged
- check.mjs: fix warning to print typecheckCmd (the resolved command)
  rather than stack.typecheck (the config value before resolution)
- cli.mjs: add early --help/-h check before ensureDependencies() to
  avoid installing packages just to print usage text

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: JustAGhosT

.agentkit/engines/node/src/check.mjs

@@ -23,6 +23,27 @@ import { commandExists, execCommand, formatDuration, isValidCommand } from './ru
  * @param {string} projectRoot - Project root path
  * @returns {string} Command to run
  */
+/**
+ * Detect the package manager in use for a project.
+ * Checks package.json#packageManager first, then falls back to lockfile detection.
+ * @param {string} projectRoot
+ * @param {object} [pkg] - Already-parsed package.json (optional, avoids re-read)
+ * @returns {'pnpm'|'yarn'|'npm'}
+ */
+function detectPackageManager(projectRoot, pkg) {
+  // 1. Explicit declaration in package.json
+  const pmField = pkg?.packageManager;
+  if (typeof pmField === 'string') {
+    if (pmField.startsWith('pnpm')) return 'pnpm';
+    if (pmField.startsWith('yarn')) return 'yarn';
+    if (pmField.startsWith('npm')) return 'npm';
+  }
+  // 2. Lockfile heuristic
+  if (existsSync(resolve(projectRoot, 'pnpm-lock.yaml'))) return 'pnpm';
+  if (existsSync(resolve(projectRoot, 'yarn.lock'))) return 'yarn';
+  return 'npm';
+}
+
 function resolveTypecheckCommand(stack, projectRoot) {
   if (stack.name !== 'node' || !stack.typecheck || !projectRoot) return stack.typecheck;
   try {
@@ -32,7 +53,9 @@ function resolveTypecheckCommand(stack, projectRoot) {
     const script = pkg.scripts?.typecheck;
     if (typeof script !== 'string' || !script.trim()) return stack.typecheck;
     if (/^node\s+-e\s+/.test(script.trim())) return script.trim();
-    return 'pnpm typecheck';
+    const pm = detectPackageManager(projectRoot, pkg);
+    // pnpm and yarn can run scripts without the `run` sub-command
+    return pm === 'npm' ? 'npm run typecheck' : `${pm} typecheck`;
   } catch {
     /* ignore */
   }
@@ -89,7 +112,7 @@ function buildSteps(stack, flags, agentkitRoot, projectRoot) {
   if (stack.typecheck) {
     const typecheckCmd = resolveTypecheckCommand(stack, projectRoot);
     if (!isValidCommand(typecheckCmd)) {
-      console.warn(`[agentkit:check] Skipping invalid typecheck command: ${stack.typecheck}`);
+      console.warn(`[agentkit:check] Skipping invalid typecheck command: ${typecheckCmd}`);
     } else {
       steps.push({
         name: 'typecheck',

.agentkit/engines/node/src/cli.mjs

@@ -492,6 +492,12 @@ async function main() {
     process.exit(1);
   }
 
+  // Early --help check before dependency installation to avoid side effects.
+  if (commandArgs.includes('--help') || commandArgs.includes('-h')) {
+    showHelp();
+    process.exit(0);
+  }
+
   if (!ensureDependencies(AGENTKIT_ROOT)) {
     process.exit(1);
   }

.agentkit/vitest.config.mjs

@@ -9,9 +9,9 @@ export default defineConfig({
       GIT_CONFIG_KEY_0: 'commit.gpgsign',
       GIT_CONFIG_VALUE_0: 'false',
     },
-  },
-  coverage: {
-    provider: 'v8',
-    reporter: ['text', 'text-summary'],
+    coverage: {
+      provider: 'v8',
+      reporter: ['text', 'text-summary'],
+    },
   },
 });