fix: #140 Add PHPStan and update code to meet level 0

.gitignore

@@ -1,2 +1,3 @@
 /composer.lock
+/phpstan.neon
 /vendor

DEVELOP.md

@@ -20,3 +20,10 @@ To run a single test use PHPUnit's `--filter` option:
 ```
 ddev exec phpunit ./tests --debug --filter=testCannotProtectNonComposerRepository
 ```
+
+## Static analysis
+
+To run PHPStan against the codebase:
+```
+ddev composer phpstan
+```

composer.json

@@ -26,7 +26,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Tuf\\ComposerIntegration\\Tests\\": "tests/"
+            "Tuf\\ComposerIntegration\\Tests\\": "tests/",
+            "Tuf\\Tests\\": "vendor/php-tuf/php-tuf/tests/"
         }
     },
     "extra": {
@@ -37,9 +38,11 @@
         "composer/composer": "^2.9",
         "phpunit/phpunit": "^9.5",
         "symfony/process": "^6",
-        "dms/phpunit-arraysubset-asserts": "^0.5.0"
+        "dms/phpunit-arraysubset-asserts": "^0.5.0",
+        "phpstan/phpstan": "^2.1"
     },
     "scripts": {
+        "phpstan": "phpstan",
         "test": [
             "phpunit ./tests --debug"
         ]

phpstan.neon.dist

@@ -0,0 +1,5 @@
+parameters:
+  level: 0
+  paths:
+    - src
+    - tests

src/ComposerFileStorage.php

@@ -14,7 +14,7 @@ class ComposerFileStorage extends FileStorage
     /**
      * {@inheritDoc}
      */
-    public function __construct(string $basePath)
+    final public function __construct(string $basePath)
     {
         (new Filesystem())->ensureDirectoryExists($basePath);
         parent::__construct($basePath);

tests/FunctionalTestBase.php

@@ -39,10 +39,6 @@ protected function setUp(): void
         $this->workingDir = uniqid(sys_get_temp_dir() . '/');
         mkdir($this->workingDir . '/tuf', recursive: true);
 
-        // Make PHP-TUF's fixture builder available.
-        $loaders = ClassLoader::getRegisteredLoaders();
-        reset($loaders)->addPsr4('Tuf\\Tests\\', key($loaders) . '/php-tuf/php-tuf/tests');
-
         // Generate the fixture.
         $this->fixture = new Fixture($this->workingDir);
         $this->fixture->root->consistentSnapshot = true;