Added fallback to master when detected branch name is unknown#12
Open
Bilge wants to merge 1 commit intophp:masterfrom
Open
Added fallback to master when detected branch name is unknown#12Bilge wants to merge 1 commit intophp:masterfrom
Bilge wants to merge 1 commit intophp:masterfrom
Conversation
derickr
requested changes
Apr 3, 2024
| throw new Exception("Unsupported branch '$name'"); | ||
| fwrite(STDERR, "Unsupported branch '$name'. Falling back to 'master'."); | ||
|
|
||
| $name = 'master'; |
Member
There was a problem hiding this comment.
I prefer the hard failure, instead of a soft fallback that could indicate user error.
Member
There was a problem hiding this comment.
Maybe for unsupported branches (and no Git available; thanks, I was missing this in my reply to #11), the user should explicitly specify the branch. If I'm not mistaken, passing -b master should work in this case already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #11. It seems this would not happen if
git.exeis detected on the path, but in case it isn't, this supports the case where git is not available.