Merged
Conversation
przepompownia
changed the title
przepompownia
force-pushed
the
refactor-constructors
branch
2 times, most recently
from
47e9998 to
11b25a8
Compare
This change (by `ClassPropertyAssignToConstructorPromotionRector` Rector rule) does not touch properties with initializers as default value (to be done separately).
przepompownia
force-pushed
the
refactor-constructors
branch
from
11b25a8 to
5ed700e
Compare
Contributor
|
nice 👍 |
Contributor
Author
|
Thanks! I'm trying to better understand how amp v2 and v3 work (down to Revolt and fibers) and I keep making stupid mistakes there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change (by
ClassPropertyAssignToConstructorPromotionRectorRector rule) does not touch properties with initializers as default value (to be done separately).