Refactor: use new in declaration defaults#64
Merged
dantleech merged 1 commit intophpactor:masterfrom Dec 16, 2025
Merged
Conversation
Contributor
|
Just as an FYI this might also make sense to run on the main phpactor as well. |
Contributor
Author
Why not, though that's where my attention is right now. The previous and next commits used Rector rules. I made this change manually reviewing about 27 occurrences of |
mamazu
added a commit
to mamazu/phpactor
that referenced
this pull request
Dec 19, 2025
mamazu
added a commit
to mamazu/phpactor
that referenced
this pull request
Dec 19, 2025
dantleech
pushed a commit
to phpactor/phpactor
that referenced
this pull request
Dec 20, 2025
* Use new for defaults in promoted properties See phpactor/language-server#64 * Fixing stricter types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.