Fixes from Codex review rounds 2-4 and the deferred ban-group tracking - #38

Merged

bonelifer merged 17 commits into

codex-review-round-2

Sep 28, 2026

Commits on Sep 22, 2026

fix(security): register m_banhammer_del_posts_all with core.permissions

bonelifer
and
claude
committed
814cbbf
fix(security): re-validate move/restrict groups at use time, not just save

bonelifer
and
claude
committed
a0254d4
fix: undo_bh_group compares the restriction's own recorded group

bonelifer
and
claude
committed
352e7b2
fix: check group_user_add() result and guard against concurrent restrictions

bonelifer
and
claude
committed
e42d7f1
fix: stop wiping unrelated account data when del_posts has no effect

bonelifer
and
claude
committed
4afa65e
fix: reject self-service restrict groups and preserve the SFS key without cURL

bonelifer
and
claude
committed
f83744f
chore: ignore local review write-ups

bonelifer
and
claude
committed
e2ad91e

Commits on Sep 23, 2026

fix: reject Open/Free restrict groups at use time too, not just save

bonelifer
and
claude
committed
a1641fa
fix: track whether a restriction created its own group membership

bonelifer
and
claude
committed
1c7d648
fix: stop del_posts cleanup when the target simply has no posts

bonelifer
and
claude
committed
eee5fff
fix: deduplicate leftover restriction rows before adding the unique index

bonelifer
and
claude
committed
b79967d
fix: hide Open/Free groups from the restrict-group dropdown

bonelifer
and
claude
committed
be9676c
fix: correct legacy-row default and add a purge fallback for restrict_new_membership

bonelifer
and
claude
committed
aa5e879
fix: apply the empty-posts guard unconditionally, stop wiping topics_posted

bonelifer
and
claude
committed
cd7e2d1
fix: give bans per-action group tracking, same as restrictions

bonelifer
and
claude
committed
3dbc19d

Commits on Sep 28, 2026

Merge master (#37) into codex-review-round-2

bonelifer
and
claude
committed
1d66ef4
Update the restriction expiry test for restrict_new_membership

bonelifer
and
claude
committed
6cf891a