Require PHP 7.4 and phpBB 3.3.19, and add a PHP lint workflow - #8
Merged
Merged
Conversation
Tested on phpBB 3.3.19 under PHP 8.4. The lint workflow checks PHP syntax on 7.4 (the new minimum) and 8.4 (the newest phpBB 3.3 supports). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer.json: PHP minimum raised to>=7.4. phpBB 3.3 itself needs 7.2, and anything older than 7.4 isn't worth supporting.composer.json: phpBB range>=3.3.19,<4.0.0@dev. The old range claimed the extension did not support phpBB 3.3, which is no longer true..github/workflows/lint.yml:php -lon every PHP file pluscomposer validate, on PHP 7.4 (the new minimum) and 8.4 (the newest phpBB 3.3 supports).tests.ymlalready covers PHP 8.2 with phpBB's code sniffer and EPV.Test plan
Claude installed the extension from
masteron a fresh phpBB 3.3.19 board (SQLite, PHP 8.4), enabled it, and checked:Investigated and written by Claude on behalf of William Jacoby (bonelifer).