Skip to content

Translate the old-extension message in ext.php #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonelifer merged 1 commit into from
Oct 7, 2026
Merged

Translate the old-extension message in ext.php #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions ext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ public function is_enableable()

if ($this->container->get('ext.manager')->is_enabled(self::OLD_EXT_NAME))
{
return ['Disable the old "' . self::OLD_EXT_NAME . '" extension first (keep its data, do not delete it).'];
$language = $this->container->get('language');
$language->add_lang('install_wiki', 'phpbbmodders/wiki');

return $language->lang('WIKI_DISABLE_OLD', self::OLD_EXT_NAME);
}

return true;
Expand Down Expand Up @@ -202,16 +205,20 @@ protected function move_old_install()

foreach ($rows as $row)
{
if ($this->new_class_name($row['migration_name']) === $row['migration_name'])
// Other extensions' migrations may depend on ours, so their
// dependency lists are rewritten too, not just our own rows
$old_depends_on = unserialize($row['migration_depends_on'], ['allowed_classes' => false]);
$old_depends_on = is_array($old_depends_on) ? $old_depends_on : [];
$depends_on = array_map([$this, 'new_class_name'], $old_depends_on);
$name = $this->new_class_name($row['migration_name']);

if ($name === $row['migration_name'] && $depends_on === $old_depends_on)
{
continue;
}

$depends_on = unserialize($row['migration_depends_on'], ['allowed_classes' => false]);
$depends_on = is_array($depends_on) ? array_map([$this, 'new_class_name'], $depends_on) : [];

$db->sql_query('UPDATE ' . $prefix . 'migrations SET ' . $db->sql_build_array('UPDATE', [
'migration_name' => $this->new_class_name($row['migration_name']),
'migration_name' => $name,
'migration_depends_on' => serialize($depends_on),
]) . " WHERE migration_name = '" . $db->sql_escape($row['migration_name']) . "'");
}
Expand Down
1 change: 1 addition & 0 deletions language/en/install_wiki.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@

$lang = array_merge($lang, [
'WIKI_NOT_ENABLEABLE' => 'phpBB Modders Wiki could not be enabled. The minimum requirements of phpBB 3.3.19 and/or PHP 7.4.0 were not satisfied.',
'WIKI_DISABLE_OLD' => 'Disable the old “%s” extension first. Keep its data; do not delete it.',
]);
Loading