Repository navigation
Space the edit form labels from their fields and align the reason line - #41
Merged
Merged
Conversation
The label column had no padding, so help text touched its textarea, and the reason-for-change row used the centred submit layout, which pushed its input far from the label. The description box is 76 columns like the others, so it no longer drops below its label on phpBB 4.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three layout fixes on the article edit form.
Help text touched its textarea. The label column had no right padding, so under "Sources" the help text ran straight into the box. Labels now have 1em of padding on the right, in both panels of the form.
"Reason for change" sat far from its label. That row lived in the centred layout used for the submit buttons, which made the label column 410px wide and pushed the input to the right. It now uses the same 15em label column as the other rows, so the input lines up with the fields above it.
The description box dropped below its label on phpBB 4.0. It was 100 columns wide, too wide to sit beside the label and past the panel edge. It is now 76 columns, like the article text and sources boxes.
Tested
Investigated and written by Claude on behalf of William Jacoby (bonelifer).