feat: Safe protection suite#69
Open
makemake-kbo wants to merge 6 commits into
Open
Conversation
makemake-kbo
requested review from
fredo,
lean-apple and
mateo-mro
as code owners
fredo
reviewed
May 22, 2026
fredo
reviewed
May 22, 2026
fredo
reviewed
May 22, 2026
Drop incorrect 'with calldata' qualifier on unknown-target blocking and split the short-calldata bullet so allowEmptyCalldata (zero bytes) and allowFallbackCalldata (one to three bytes) are named separately.
Skips assertion runs for txs that don't touch Safe storage (view-only calls and module txs that only call external contracts). Tests that relied on no-op calls now perform a benign threshold write to exercise the trigger.
fredo
reviewed
May 26, 2026
fredo
reviewed
May 26, 2026
fredo
reviewed
May 26, 2026
…ce cap - Add (token, spender, kind) and (token, kind) mappings populated alongside the existing array so approval enforcement no longer scans on every action. - For ERC20 increaseAllowance, bind the policy cap to the post-state allowance(safe, spender) instead of the per-call addedValue, so two consecutive increases inside a MultiSend cannot stack above maxAmount. - README: clarify approve vs. increaseAllowance cap semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.