feat: adapt to new foundry rebase upstream#85
Draft
lean-apple wants to merge 16 commits into
Draft
Conversation
Ports phylax-specific work from PR #84 (originally rebased to v1.7.1) onto current main (v1.7.2). Includes: - CI: GitHub App token for cross-repo cargo auth across all jobs - CI: inline cargo-deny job; drop tempo/mpp/bump-tempo workflows - deps: track credible-sdk ENG-3169 branch + reth-core split crates - deny.toml: advisory ignores for phoundry 1.7 / revm 38 dep graph - cheatcodes: port credible cheatcode to generic EVM context (rename assertionEx -> assertion(address,bytes,bytes4)) - backend: preserve configured spec (evm_version) across fork switches - testdata: Vm.sol regen, credible test fixture updates Cargo.lock is reset to main's; run cargo build to refresh.
lean-apple
changed the title
Also: update CodeQL action SHAs to v4.35.2.
… WrapDatabaseRef hack
… in credible-sdk)
lean-apple
commented
May 26, 2026
lean-apple
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
lean-apple
commented
May 26, 2026
| .filter(|arena| !arena.nodes().is_empty()); | ||
| cheats.push_assertion_trigger_traces(trigger_traces); | ||
| } | ||
| // TODO: restore -vvv assertion tracing once credible-sdk's |
Author
There was a problem hiding this comment.
@odyslam @makemake-kbo how important is it to keep this ?
Collaborator
There was a problem hiding this comment.
I am not sure what this does, but creating traces for the assertion execution and printing them is very important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the phylax-specific work originally landed in #84 (rebased onto foundry v1.7.1) on top of current
main(already at foundry v1.7.2). #84 became out of date whenmainwas force-pushed past v1.7.1.What's included
actions/create-github-app-token) for cross-repo cargo auth acrossdoctest,no-default-features,clippy,forge-fmt,crate-checks,deny. Dropsbump-tempo,ci-mpp,ci-tempoworkflows.cargo-denyjob (replaces externaltempoxyz/cireusable workflow) with sccache + GH App token.credible-sdkENG-3169 branch + addreth-coresplit-crate pins (workspace level).assertionEx(bytes,address,bytes,string)toassertion(address,bytes,bytes4).evm_version) acrossselect_fork/roll_forkso user hardfork setting isn't overridden by fork's default spec.Credible.t.solfixture updates, foundry.lock, ds-test src.Notes
Cargo.lockis reset to main's; runcargo buildlocally to refresh against the newcredible-sdkENG-3169 rev andreth-corepins.mainwhere it has newer foundry work (spec preservation, innermost-revert CREATE semantics, env-overrides fields onCheatcodes).Test plan
cargo build --workspace --lockedcargo test --workspace --doc --lockedcargo clippy --workspace --all-targets --all-features --lockedcargo deny --all-features checkforge testagainsttestdata/(credible tests)