Wip/bhahn/6.18.20 2.0.0 phy initial#11
Conversation
This is only a copy of mx95lp5. No changes made so far. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Modify README to fit iMX95 Libra board. (cherry-picked from commit e5f00a9) Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
ignore build directory and compilation database. Signed-off-by: Yannic Moog <y.moog@phytec.de> (cherry-picked from commit 6d3144b) Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Add ccache to example CROSS_COMPILE Signed-off-by: Yannic Moog <y.moog@phytec.de> (forwardported from commit 1f811bb) Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Without the DEBUG option there is no output from OEI, as NXP disables all printf globally when DEBUG option is not set. Even non DEBUG messages do not get printed then. Do not disable printf globally, so non DEBUG messages are still printed. Note: printf in tcm oei does not work at the moment. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de> (forwardported from commit 996be58) Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Make B0 the default silicon revision. We will base our imx95 release on this and will use the B0 silicon revision not the A0/A1. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de> (cherry picked from commit 22e056d) Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
BHahn42618
force-pushed
the
WIP/bhahn/6.18.20-2.0.0-phy_initial
branch
from
59af72d to
a42fdb6
Compare
BHahn42618
requested review from
jremmet and
ymoog
and removed request for
jremmet
Remove code for the unused debug UART. Libra can only use LPUART2 as debug UART. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Remove code in #if 0 as it is never compiled. Also remove the variable and type conversion, as it is only used once. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
| IOMUXC_SetPinMux(IOMUXC_PAD_UART1_TXD__LPUART1_TX, 0); | ||
| IOMUXC_SetPinConfig(IOMUXC_PAD_UART1_TXD__LPUART1_TX, IOMUXC_PAD_DSE(0xFU)); | ||
| #elif (BOARD_DEBUG_UART_INSTANCE == 2U) | ||
| #if (BOARD_DEBUG_UART_INSTANCE == 2U) |
There was a problem hiding this comment.
remove the #if condition. LPUART2 should always be muxed.
There was a problem hiding this comment.
Why? This is pin muxing for LPUART2. For our board this is currently always applied, as BOARD_DEBUG_UART_INSTANCE is set to 2U for our board. If someone would change that, this pinmuxing should not be applied.
There was a problem hiding this comment.
I think it is bad enough to remove the pinmuxing for LPUART1. Our customer has the same relationship to us as we have to NXP. NXP uses LPUART1 for us, we decided to use LPUART2. We have to change some code for that to work, but NXP does not "lay stones in our way". The code is "nicely prepped" by NXP. Why should we now go ahead and actively remove the option to use LPUART1 for our customer. This does not make any sense. This is bad for us, as it will give us merge conflicts when NXP decides to change something in this code. And it will make our customer angry at us, because he will have more work to do, if he decides for any reason he wants or needs to use LPUART1 here (Same as we do in regard to NXP). This code does not hurt anyone and also does not make it harder to read. It is well structured and easy to understand, so I do not see any reason at all to remove it.
2 participants
Forwardport patches from 6.12.34-2.1.0-phy branch for initial support.
Split the initial support commit. The first commit now is only a copy of mx95lp5 board and the second commit does the changes to the board needed for libra similar to imx-sm commit. This makes future forwardporting much easier.