Repository navigation
2026.08.17 - Statusbar Sidebar Visibility - Phase 1: Backward-Compatible Config Schema - #85
Merged
lanhhoang merged 6 commits intoAug 18, 2026
Conversation
lanhhoang
commented
Aug 18, 2026
lanhhoang
commented
Contributor
- Implement statusbar and sidebar visibility configuration
Phase 1 of the statusbar/sidebar visibility plan. Both fields are required booleans on PiStatusConfig with enabled-by-default semantics; only the literal stored value false disables a field, all other values (missing, true, null, 0, strings, objects, arrays) normalize to true. saveConfig emits both fields in the canonical serialized schema.
Phase 1 of the statusbar/sidebar visibility plan. Adds a new
`config — surface visibility` describe block asserting:
- both fields default to true when absent
- non-false values (true, null, 0, 'false', {}, []) normalize to true
- literal false disables only the targeted surface
- saveConfig round-trips both fields and includes them in the
serialized schema
Also adds the new fields to the canonical in-memory fixture and updates
exact-equality expectations in malformed/missing-config and serialized-
key tests to match the new schema.
Phase 1 of the statusbar/sidebar visibility plan. Both fields are now required on PiStatusConfig, so every in-memory typed fixture across the test suite needs the defaults (true, true). Also updates one persisted-schema expectation in index.test.ts to include the new keys in the round-tripped JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.