fix(release): bound anonymous repository probe - #5
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughWhen ChangesExternal link validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e883a7ed4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await reachable(`${repositoryOrigin}${repositoryPrefix}`, { | ||
| origin: repositoryOrigin, | ||
| pathPrefix: repositoryPrefix, | ||
| }); |
There was a problem hiding this comment.
Restore reachability checks for metadata endpoints
When the repository root remains public but a project endpoint is unavailable—for example, Issues is disabled or /security/policy no longer resolves—this single root request succeeds even though the wheel's advertised [project.urls] link is broken. projectMetadataUrls() only compares those URLs with a hard-coded map, and the local repository-link validation never checks endpoint availability, so removing the small projectUrls reachability loop allows the publication gate in .github/workflows/release.yml to promote packages with dead metadata links; keep bounded probes for these distinct metadata destinations.
Useful? React with 👍 / 👎.
| // Repository-link structure and file existence were already checked against | ||
| // this exact checkout above. One anonymous request proves the repository | ||
| // origin is public without turning hundreds of rendered source links into a | ||
| // GitHub availability/load test. |
There was a problem hiding this comment.
Preserve validation for links targeting main
When the workflow resumes an older tagged release after main has removed or renamed a source file, the local check validates the link against the old release checkout even though generated links such as those from docs/astro.config.mjs target blob/main/.... The recovery path in .github/workflows/release.yml explicitly permits the release tag to be an ancestor of the current workflow commit, so repository-root reachability does not prove those moving-branch URLs exist and the gate can promote documentation containing broken source links; retain a bounded way to validate main targets or generate immutable links instead.
Useful? React with 👍 / 👎.
Promotion record
bb94344a6521a7f4f0ba08586e494d5fa60cf5903d50487001a49c257ea8e77998e6aed9c30b3e3c2d6347c430ba40f6c9908c1fSummary by CodeRabbit