Repository navigation
Fix AttributeError when creating TPLinkDeviceManager without credentials - #77
Merged
Merged
Conversation
Initialize _auth_token to None in __init__ to prevent AttributeError when accessing the attribute before login() is called. This allows users to create a TPLinkDeviceManager without credentials and set the auth token later via set_auth_token(), which is useful for caching tokens to avoid API rate limits. Fixes #75
piekstra
force-pushed
the
piekstra/75-fix-auth-token-initialization
branch
from
February 7, 2026 04:06
025c613 to
0fd22ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#75]
Summary
_auth_tokentoNonein__init__to preventAttributeErrorwhen accessing the attribute beforelogin()is calledProblem
When creating a
TPLinkDeviceManagerwithout credentials (to set auth token later viaset_auth_token()), anAttributeErroris raised because_auth_tokenis never initialized.This is a valid use case for users who want to cache their auth tokens to avoid API rate limits (see issue discussion).
Test plan
_auth_tokenis accessible and settable without credentialsCI Note
This PR should be rebased after #80 is merged to get CI passing.