Repository navigation
Handle responseData as both string and dict - #79
Merged
Merged
Conversation
Some devices (e.g., Archer routers) return responseData as an already- parsed dict instead of a JSON string. This change handles both cases by checking the type before attempting JSON parsing. Fixes #65
piekstra
force-pushed
the
piekstra/65-fix-responsedata-type-handling
branch
from
February 7, 2026 04:06
8bf9dba to
6e9c787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#65]
Summary
TypeErrorwhen devices returnresponseDataas a dict instead of a JSON stringpass_through_requestcovering both casesProblem
Some devices (e.g., Archer A8 routers) return
responseDataas an already-parsed dict rather than a JSON string. The code was unconditionally callingjson.loads()which fails with:Solution
Check the type of
responseDatabefore attempting to parse it:json.loads()Test plan
Note
This may not fully resolve Archer router support since the device commands may differ from smart plugs. However, this fix removes the immediate crash and allows further investigation.
CI Note
This PR should be rebased after #80 is merged to get CI passing.