Skip to content

Update taxQuery.php #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdewouters wants to merge 1 commit into
base: fix/57300-allow-array-param-url-for-hierarchical-tax
Choose a base branch
from
Open

Update taxQuery.php #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/phpunit/tests/query/taxQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1744,4 +1744,36 @@ public function test_hierarchical_taxonomies_do_not_limit_query() {
$this->assertSameSets( array( $p ), $q->posts );
$this->assertStringNotContainsString( 'LIMIT 1', $query );
}

/**
* @ticket 57300
*
* @covers WP_Query::parse_tax_query
*/
public function test_rewrite_hierarchical_array_query_param() {
register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true, 'rewrite' => array( 'hierarchical' => true ) ) );
$name = 'foobar';
$t = self::factory()->term->create(
array(
'taxonomy' => 'wptests_tax',
'name' => $name,
)
);

$q = new WP_Query(
array(
'fields' => 'ids',
'wptests_tax' => [$name],
'tax_query' => array(
array(
'taxonomy' => 'wptests_tax',
'field' => 'name',
'terms' => $name,
),
),
)
);
// If we got this far, no errors were thrown.
$this->expectNotToPerformAssertions();
}
}