[diffs/edit] Add search-match viewport culling#1008
Merged
Conversation
- Binary-searches offset-sorted matches for each rendered line segment. - Skips virtualized offscreen matches and matches hidden inside collapsed diff gaps.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
amadeus
approved these changes
Jul 21, 2026
amadeus
pushed a commit
that referenced
this pull request
Jul 21, 2026
- Binary-searches offset-sorted matches for each rendered line segment. - Skips virtualized offscreen matches and matches hidden inside collapsed diff gaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes search-match overlay renders all matches with no viewport culling by: