[diffs] Byte arena parsing experiments

apps/diffshub/components/usePatchLoader.ts

@@ -4,7 +4,9 @@ import {
   areSelectionsEqual,
   type CodeViewItem,
   type CodeViewLineSelection,
-  processFile,
+  getStreamedPatchMetadata,
+  processFileBytes,
+  streamGitPatchFiles,
 } from '@pierre/diffs';
 import { type CodeViewHandle, useStableCallback } from '@pierre/diffs/react';
 import {
@@ -32,10 +34,6 @@ import {
   formatDiffsHubLineHash,
   parseDiffsHubLineHash,
 } from '@/lib/lineHash';
-import {
-  getStreamedPatchMetadata,
-  streamGitPatchFiles,
-} from '@/lib/streamGitPatchFiles';
 import type {
   CommentMetadata,
   DiffsHubCommentFileByItemId,
@@ -404,20 +402,20 @@ export function usePatchLoader({
 
           publishTreeSource();
         };
-        const appendStreamedFile = async (fileText: string) => {
+        const appendStreamedFile = async (fileBytes: Uint8Array) => {
           if (!hasReceivedFirstStreamedFile) {
             hasReceivedFirstStreamedFile = true;
           }
 
-          const patchMetadata = getStreamedPatchMetadata(fileText);
+          const patchMetadata = getStreamedPatchMetadata(fileBytes);
           if (patchMetadata != null) {
             streamTreePathPrefix = getPatchTreePathPrefix(
               patchMetadata,
               streamPatchIndex++
             );
           }
 
-          const fileDiff = processFile(fileText, {
+          const fileDiff = processFileBytes(fileBytes, {
             cacheKey: `${cacheKeyPrefix}-0-${accumulator.fileIndex}`,
             isGitDiff: true,
           });

apps/diffshub/lib/gitPatchMetadata.ts

@@ -1,4 +1,4 @@
-export const COMMIT_HASH_METADATA_PATTERN = /^From\s+([a-f0-9]+)\s/im;
+import { COMMIT_HASH_METADATA_PATTERN } from '@pierre/diffs';
 
 const commitPrefixEncoder = new TextEncoder();
 const commitPrefixDecoder = new TextDecoder();

packages/diffs/src/editor/editor.ts

@@ -20,6 +20,7 @@ import type {
   SelectionSide,
   TextEdit,
 } from '../types';
+import { joinLines } from '../utils/diffLines';
 import { getFiletypeFromFileName } from '../utils/getFiletypeFromFileName';
 import { isGutterUtilityPath } from '../utils/isGutterUtilityPath';
 import {
@@ -905,7 +906,7 @@ export class Editor<LAnnotation> implements DiffsEditor<LAnnotation> {
       if ('contents' in fileOrDiff) {
         contents = fileOrDiff.contents;
       } else {
-        contents = fileOrDiff.additionLines.join('');
+        contents = joinLines(fileOrDiff.additionLines);
       }
       const editStack = new EditStack<LAnnotation>({
         maxEntries: this.#options.historyMaxEntries,

packages/diffs/src/index.ts

@@ -78,6 +78,7 @@ export * from './utils/createWindowFromScrollPosition';
 export * from './utils/cssWrappers';
 export * from './utils/detachString';
 export * from './utils/diffAcceptRejectHunk';
+export * from './utils/diffLines';
 export * from './utils/formatCSSVariablePrefix';
 export * from './utils/getFiletypeFromFileName';
 export * from './utils/getHighlighterOptions';
@@ -99,6 +100,7 @@ export * from './utils/parseDiffDecorations';
 export * from './utils/parseDiffFromFile';
 export * from './utils/parseLineType';
 export * from './utils/parsePatchFiles';
+export * from './utils/parsePatchStream';
 export * from './utils/prefersReducedMotion';
 export * from './utils/prerenderHTMLIfNecessary';
 export * from './utils/processLine';