Skip to content

Silence git stderr in non-repository folders (fixes 'fatal: not a git repository' noise) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
D3mianGianoz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Silence git stderr in non-repository folders (fixes 'fatal: not a git repository' noise) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions extensions/yolo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ export default function yolo(pi: ExtensionAPI) {
encoding: "utf8",
timeout: 2000,
windowsHide: true,
stdio: ["ignore", "pipe", "ignore"],
}).trim();
} catch {
return null;
Expand All @@ -158,14 +159,15 @@ export default function yolo(pi: ExtensionAPI) {
*/
function gitCheckpoint(cwd: string, now: number): CheckpointResult {
const runGit = (args: string[]): string =>
execFileSync("git", args, { cwd, encoding: "utf8", timeout: 5000, windowsHide: true }).toString();
execFileSync("git", args, { cwd, encoding: "utf8", timeout: 5000, windowsHide: true, stdio: ["ignore", "pipe", "ignore"] }).toString();
const result = decideCheckpoint(runGit);
if ("sha" in result) {
try {
execFileSync("git", ["update-ref", `refs/pify/yolo/${now}`, result.sha], {
cwd,
timeout: 5000,
windowsHide: true,
stdio: ["ignore", "pipe", "ignore"],
});
} catch {
// unreachable-but-recent commits still survive the default gc window
Expand Down Expand Up @@ -381,7 +383,7 @@ Go ahead anyway?`));
function releaseRefs(cwd: string, refs: string[]): void {
for (const ref of refs) {
try {
execFileSync("git", ["update-ref", "-d", ref], { cwd, timeout: 5000, windowsHide: true });
execFileSync("git", ["update-ref", "-d", ref], { cwd, timeout: 5000, windowsHide: true, stdio: ["ignore", "pipe", "ignore"] });
} catch {
// already gone, or not a repo any more
}
Expand Down Expand Up @@ -926,6 +928,7 @@ Go ahead anyway?`));
cwd: ctx.cwd,
timeout: 30_000,
windowsHide: true,
stdio: ["ignore", "pipe", "ignore"],
});
ctx.ui.notify(`Working tree restored to ${point.treeSha?.slice(0, 8)}.`, "info");
} catch (err) {
Expand Down