fix: adapt to AmberMpris changes compared to QtMpris (another atempt)#19
Closed
jmlich wants to merge 5 commits intopiggz:masterfrom
Closed
fix: adapt to AmberMpris changes compared to QtMpris (another atempt)#19jmlich wants to merge 5 commits intopiggz:masterfrom
jmlich wants to merge 5 commits intopiggz:masterfrom
Conversation
jmlich
changed the title
Contributor
|
I'd prefer it if you just review my PR and tell me what I need to change so I can fix it myself and we'll just get it in correctly directly there, rather than you making another branch which includes my changes plus some of your own stuff. |
Contributor
Author
|
I am sorry, In some point testing turned to debugging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #18
fixes showing of title, album, and artist - using pointer instead of copy
artist is actualy in contributingArtist field.
adding some qml interface for convinient testing.
fixes duration (removes
/1000)