fix: enforce PR action modes from intent#148
Conversation
pilipilisbot
left a comment
There was a problem hiding this comment.
Approved. I reviewed the parser/classifier/queue/executor changes and the prompt/documentation updates for the action-mode boundary.
What I checked:
- Assignments and bot-authored PR discussions no longer upgrade
review_onlyjobs towork_allowed; executor now only records that the action mode was retained. - The intent classifier receives configured bot/agent identity, normalizes unaddressed events to
archive_notification, and requireswrite_permission=state_change_allowedbefore acceptingwork_allowed. - The dispatcher exposes the effective action mode in the prompt and environment while preserving existing review-only prompt rules.
- GitHub CI is green for dashboard and pytest on Python 3.11/3.12.
- Local
git diff --checkandpython3 -m py_compileover the changed Python modules/tests pass.
I could not rerun the pytest suite locally because this container has no repo virtualenv, no uv, and global python3 lacks pytest, but the CI result covers the suite. No blocking findings from the review.
pilipilisbot
left a comment
There was a problem hiding this comment.
Reviewed the new dashboard commit (fa002b1) on top of the earlier approved action-mode changes. The added job-detail panel exposes the effective action mode and intent-classifier metadata without changing dispatch behavior, and the backend keeps the dashboard data shape scoped to job metadata.
Checks:
- GitHub CI is green:
dashboard,pytest (3.11), andpytest (3.12). - Local
python3 -m py_compilepassed for the changed Python modules/tests. - Local
git diff --check c52e43e..fa002b1passed.
I could not rerun local pytest/vitest/tsc in the clean worktree because this container has no pytest, vitest, or tsc installed there, but CI covers those suites. No blocking findings from the latest delta.
|
Post-merge follow-up: PR #148 is merged as No additional repository changes are needed from this merge event. |

Summary
Tests
.venv/bin/python -m pytest tests/test_parser.py tests/test_intent_classifier.py tests/test_queue.py tests/test_executor.py tests/test_prompt_rules.py -q.venv/bin/python -m pytest -q --ignore=tests/test_backend.pycd dashboard && npm run lintcd dashboard && npm test -- src/main.test.tsxgit diff --checkNote
.venv/bin/python -m pytest -qsegfaulted in the local Python 3.14 environment inside_asyncio/StarletteTestClientwhile running backend tests; no assertion failure was reported before the interpreter crash. CI runs pytest on Python 3.11/3.12.