Skip to content

fix: preserve work intent when normalizing permissions#149

Open
giscebot wants to merge 1 commit into
pilipilisbot:mainfrom
gisce:fix/intent-write-permission-normalization
Open

fix: preserve work intent when normalizing permissions#149
giscebot wants to merge 1 commit into
pilipilisbot:mainfrom
gisce:fix/intent-write-permission-normalization

Conversation

@giscebot

@giscebot giscebot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Treat work_intent as canonical when normalizing intent-classifier output.
  • Normalize inconsistent write_permission values to match work_intent instead of downgrading work_allowed to review_only.
  • Expose normalization_warnings in intent-classifier metadata when a field is corrected.

Why

A trusted PR comment asking @giscebot to add an e2e test produced raw LLM output with work_intent=work_allowed and write_permission=none. The previous normalizer silently converted that to review_only, making the dashboard look like the LLM had classified the request as read-only.

Tests

  • pytest tests/test_intent_classifier.py tests/test_parser.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant