Closed
Conversation
Author
|
Please let me know your thoughts at your earliest convenience. |
Member
|
@re-taro there is a policy in the oven regarding ESM expressjs/discussions#323. I hope that this can give you additional context 👍 |
Member
|
Unfortunately, as mentioned in the issues you linked to, this won't land until there's a new major. I don't believe this is backward compatible because anyone it will change the imports for anyone using ESM to import from CommonJS today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ESM (ECMAScript Module) support alongside existing CommonJS compatibility. This change enables the package to be used with both import and require statements, providing better compatibility with modern JavaScript tooling and environments.
Resolves: #346
Resolves: #347
Changes
Technical Details
Breaking Changes
None. This change maintains full backward compatibility with existing CommonJS consumers while adding ESM support.