Merged
Conversation
- **BREAKING:** Renamed `pathbridge.extras.trace_converter(...)` keyword-only parameters: - `model_module` -> `destination_module` - `converter` -> `facade_to_destination` - `lift` -> `lift_functions` - `root_tag` -> `facade_root_tag` - **BREAKING:** Renamed `pathbridge.extras.build_rules(...)` keyword-only parameters: - `model_module` -> `destination_module` - `converter` -> `facade_to_destination` - `shape` -> `facade_shape` - `lift` -> `lift_functions` - `root_tag` -> `facade_root_tag` - Removed old keyword aliases for the renamed arguments.
Changed: - updated argument names to match tracer's params - support file paths along with pkg.module format for output-package, facade-class, destination-module, facade-to-destination options Added: - emit option to control raw/compiled/both rules output
`make ci` to run linters, typechecker and test-matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
pathbridge compileCLI command to generate Python modules withRAW_RULESandCOMPILED_RULES.pathbridge compilesupports both import references and file-pathreferences for facade/destination/converter inputs.
Changed
pathbridge.extras.trace_converter(...)keyword-onlyparameters:
model_module->destination_moduleconverter->facade_to_destinationlift->lift_functionsroot_tag->facade_root_tagpathbridge.extras.build_rules(...)keyword-onlyparameters:
model_module->destination_moduleconverter->facade_to_destinationshape->facade_shapelift->lift_functionsroot_tag->facade_root_tagpathbridge compileoptions:--model-module->--destination-module--converter->--facade-to-destination--rules-root-tag->--facade-root-tag--rules-lift->--lift-functions--output-packagenow expects a dotted package name(for example
generated.rules) instead of a filesystem path.--output-dirfor choosing where generated package directories are created.