Add declarative Notification payload builder#72
Open
danieldickison wants to merge 3 commits intopimeys:masterfrom
Open
Add declarative Notification payload builder#72danieldickison wants to merge 3 commits intopimeys:masterfrom
danieldickison wants to merge 3 commits intopimeys:masterfrom
Conversation
danieldickison
force-pushed
the
declarative-push
branch
from
1c00f35 to
f685dd1
Compare
Author
|
I've been using this branch on a live website for a year and it's been working well (danieldickison/kachiclash#46), so I think this is (finally) ready for review/merge. |
Collaborator
|
Code itself LGTM, I suggest adding a short code snippet at the module level to show how to use these notifcations with the client for people like myself that have been out of the loop. After that I can merge it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To aid in sending declarative web push notifications proposed by Webkit: