Fix mqtt display #144
Merged
Fix mqtt display #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous display box function wasn't properly used. This fix the information displayed on the enviro+ display. Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com>
Signed-off-by: Alexandre Esse <alexandre.esse.dev@gmail.com>
ahresse
force-pushed
the
fix-mqtt-display
branch
from
9d81273 to
f32e560
Compare
ncguerra
approved these changes
Dec 1, 2024
Pull Request Test Coverage Report for Build 21864144358Details
💛 - Coveralls |
Contributor
|
Looks good - thanks for the PR, and sorry that it took us so long to merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue when using the
mqtt-all.pyexample with my enviro+. My display wasn't displaying the right info: There was a problem with the bounding box calculation of the message.This PR is intended to fix this issue.