Add a dynamixel serial servo implementation. - #22
Conversation
|
Thank you for raising this PR! Not sure when I will get a chance to test it with my own servos, but the code seems sensible enough and doesn't modify any existing files so there'll be no impact on the rest of the Yukon system. |
|
Saying that. If you could fix the linting issues that have been raised, that would be appreciated. |
|
I have cleaned up the lint issues. |
|
Thanks for fixing the linting! As for docs, its a GitHub thing. If you're viewing a .md file it automatically parses it to produce nice formatting. If you wish to add one for your code in this PR then that would be great. I guess use my own https://github.com/pimoroni/yukon/blob/main/docs/devices/lxservo.md for reference. For seeing what you're doing, I think GH lets you edit the file in browser with a preview mode before any commit. Otherwise there's a markdown plugin for VSCode if you're using that. |
…evices section of the top level README
|
Docs added |
|
Thanks for that @JohnNichol! I won't get chance to test the library soon, but if you're happy with it and using it without issues, I'm happy to go ahead and merge it. |
|
It is working for me with 6 AX-12W Servos (I don't have any others to test with). I am happy for it to be merged and will keep an eye out for any issues that might get raised. |
This has been tested with a number of AX-12W Servos in joint and motor modes.