Skip to content

fix: stabilize RSK SIWE address assertion - #7

Merged
DenisCarriere merged 1 commit into
masterfrom
fix/rsk-siwe-address-assertion
Aug 3, 2026
Merged

fix: stabilize RSK SIWE address assertion#7
DenisCarriere merged 1 commit into
masterfrom
fix/rsk-siwe-address-assertion

Conversation

@DenisCarriere

@DenisCarriere DenisCarriere commented Aug 3, 2026

Copy link
Copy Markdown

Summary

  • compare the SIWE address case-insensitively in the account authentication test
  • preserve validation that the generated message contains the requested address
  • avoid treating RSKIP-60 casing and the SIWE serializer's Ethereum checksum casing as different addresses

Why

The expanded master matrix repeatedly failed the RSK web test when a generated address had different valid checksum casing under RSKIP-60 and the SIWE serializer. The assertion was case-sensitive even though the address bytes were identical.

Validation

  • formatted the changed test with Elixir 1.19.4 / OTP 27 in a container
  • git diff --check
  • CodeQL: passed
  • default GitHub Actions matrix: passed
  • ci:rsk GitHub Actions matrix: passed
  • RSK Blockscout Web suite: 29 doctests and 1,688 tests, 0 failures

@DenisCarriere DenisCarriere changed the title test: stabilize RSK SIWE address assertion fix: stabilize RSK SIWE address assertion Aug 3, 2026
@DenisCarriere DenisCarriere added the ci:rsk Run the RSK chain-type CI matrix label Aug 3, 2026
@DenisCarriere
DenisCarriere merged commit 8647900 into master Aug 3, 2026
34 of 35 checks passed
@DenisCarriere
DenisCarriere deleted the fix/rsk-siwe-address-assertion branch August 3, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:rsk Run the RSK chain-type CI matrix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant