fix: reject shadowed terminal array element calls#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This also corrects the alias false rejection exposed after #87. The direct defect and alias program-point defect can mask each other, so they were validated as independent factors.
Exhaustive masking matrix
Complete
2^2run, no early stop:200465f22a7f47a69e918c0fd1b202266bcb3021b5451f4b8a24ee449db30819f19ba62022d5bde3241d9bb80d63cb3dcc3c7080d6bb35ade09f0bafa5bea8b51953ee0f27ef640ae2b3905a077234cf814e4a8bd3542ae06a49b419d67919a4Validation
py_compile: 120/120git diff --check: cleanThe accepted validation board is unchanged; this is a score-neutral compiler correctness fix.