Preserve nullable matrix types#96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nato a matrix destination:=reassignments, ternary/if/switchselections, and persistent first-reach storageWhy
Pine permits matrix IDs to be
na. Codegen previously lowered barenaas scalarna<double>(), even when the destination was a typed matrix. That lost the matrix element type and could also turn persistent selection initializers into/* unknown */or silently drop them.This change is the codegen half of the nullable-matrix lifecycle fix. It targets the nullable runtime state merged in pineforge-engine PR #127 and was revalidated against merged engine
7b765aa702cc.Impact
Generated strategies now retain matrix identity and element typing across nullable lifecycle operations. Incompatible element-type reassignment remains rejected.
This PR deliberately does not add nullable arrays, matrix assignment alias semantics, matrix-returning UDF or method inference, general untyped
var x = nainference, or broader UDT identity behavior.Validation
7b765aa702cc5cab0779b4b4661ace209972656c17e9fd734588d0eb4b560b875dc36b15c33b