Fix typed method receiver parsing and dispatch#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
_parse_method_defconsumed the receiver type as a bareIDENT. Primitive receiver tokens and generic type arguments therefore triggered top-level parser recovery, silently removing an otherwise valid method declaration from the AST.An ordinary later call then failed during C++ generation. More dangerously, a dropped method such as
method push(array<int> self, ...)allowedvalues.push(...)to compile through the builtinpush_backpath, executing the wrong body while appearing successful.Validation
MethodDef; array collision emits builtinpush_backMethodDef; authored typed method dispatchescompileall,git diff --check, and manual float/bool/string receiver transpile+compile: passScope boundary
This PR does not change verifier, tier, TradingView evidence, strategy inputs, or engine runtime semantics. A separately observed single-expression matrix-method
return voidissue remains outside this fix.