Skip to content

tidb: enable global memory arbitration in priority mode by default#21827

Open
solotzg wants to merge 3 commits into
masterfrom
solotzg-patch-1
Open

tidb: enable global memory arbitration in priority mode by default#21827
solotzg wants to merge 3 commits into
masterfrom
solotzg-patch-1

Conversation

@solotzg

@solotzg solotzg commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • 文档
    • 更新系统变量 tidb_mem_arbitrator_mode 的默认值说明:从 disable 调整为 priority
    • 保留现有可选值(disablestandardpriority)及各模式含义说明不变。

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Jul 22, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

文档将系统变量 tidb_mem_arbitrator_mode 的默认值从 disable 更新为 priority,并移除 disable 枚举项的默认值标注。

Changes

系统变量文档

Layer / File(s) Summary
更新内存仲裁模式默认值
system-variables.md
tidb_mem_arbitrator_mode 的默认值更新为 priority,并移除 disable 条目的默认值标注;可选值及模式描述保持不变。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: qiancai, lilin90, guo-shaoge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning 模板结构基本齐全,但“What's changed”必填内容仍为空,缺少变更说明和原因。 补充“What is changed, added or deleted?”章节,说明修改了哪些文档、默认值为何改为 priority,以及影响范围。
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed 标题与变更一致,准确概括了将内存仲裁默认模式改为 priority。
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch solotzg-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 48be1509-3e46-4b1b-ac00-22e2be2cf8a3

📥 Commits

Reviewing files that changed from the base of the PR and between bf5af3c and 7e1af04.

📒 Files selected for processing (1)
  • system-variables.md

Comment thread system-variables.md Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fb5e85df-47b0-4576-9668-7fb6bbb3977b

📥 Commits

Reviewing files that changed from the base of the PR and between 7e1af04 and a4b7974.

📒 Files selected for processing (1)
  • system-variables.md

Comment thread system-variables.md
Add default and optional values for memory management variable.
@solotzg solotzg changed the title Update system-variables.md tidb: enable global memory arbitration in priority mode by default Jul 24, 2026
Comment thread system-variables.md
- 是否受 Hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value) 控制:否
- 类型:枚举型
- 默认值:`disable`
- 默认值:`priority`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了默认值后,相当于这个功能在所有环境都默认开启了,那前面的 “该变量控制的功能为实验特性,不建议在生产环境中使用” 还需要保留吗,有些矛盾

@qiancai qiancai self-assigned this Jul 25, 2026
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Jul 25, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jul 25, 2026
@qiancai qiancai added the v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. label Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants